Skip to content

Add tag name for MongoDB event listener #11770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2019
Merged

Add tag name for MongoDB event listener #11770

merged 1 commit into from
Jul 5, 2019

Conversation

JonathanHolvey
Copy link
Contributor

I spent a couple of hours today trying to work out why my event listener wasn't working. It turns out that the tag name for the event listener service is different when using MongoDB, and it would be really useful to have this referenced in the documentation.

@OskarStark
Copy link
Contributor

Are you using ORM and ODM in the same project?

@JonathanHolvey
Copy link
Contributor Author

JonathanHolvey commented Jun 18, 2019

No I'm not. It's there specific documentation for event listeners when using the ODM?

@OskarStark
Copy link
Contributor

OskarStark commented Jun 18, 2019

I am not quite sure, I thought that doctrine.* is always an alias for the configured one, in your case doctrine_mongodb.odm.*

maybe @alcaeus can help us out here, but he is currently on holiday ☀️

@alcaeus
Copy link
Contributor

alcaeus commented Jun 18, 2019

That’s a 👎 from me: the tutorial covers using Doctrine ORM. The MongoDB ODM docs are found elsewhere: https://symfony.com/doc/current/bundles/DoctrineMongoDBBundle/index.html

If anything at all, the main documentation page should mention that the guide covers ORM and maybe link to the ODM docs, but nothing else. If you’re adding ODM documentation there, you’ll have to add it to other parts (e.g. query builders, mapping, etc. as well which would definitely go too far IMO).

@xabbuh
Copy link
Member

xabbuh commented Jun 18, 2019

I agree with @alcaeus here.

@javiereguiluz javiereguiluz changed the base branch from 4.3 to 3.4 July 5, 2019 06:54
@javiereguiluz javiereguiluz merged commit 25f375c into symfony:3.4 Jul 5, 2019
javiereguiluz added a commit that referenced this pull request Jul 5, 2019
This PR was submitted for the 4.3 branch but it was merged into the 3.4 branch instead (closes #11770).

Discussion
----------

Add tag name for MongoDB event listener

I spent a couple of hours today trying to work out why my event listener wasn't working. It turns out that the tag name for the event listener service is different when using MongoDB, and it would be really useful to have this referenced in the documentation.

Commits
-------

25f375c Add tag name for MongoDB event listener
@javiereguiluz
Copy link
Member

Jonathan, thanks for this contribution! We merged it ... but reworded it a bit while merging to do what @alcaeus said. Thank you!

@JonathanHolvey JonathanHolvey deleted the patch-1 branch July 8, 2019 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants